[opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

> On July 21, 2011, 5:35 p.m., Kadah Coba wrote:
> > Made the requested changes. Allow setting object price without needing to commit the object for sale at the default 10L first.
> 
> Wolfpup Lowenhar wrote:
>     1. Can the price be set to 0$L.
>     2. Dose this also fix it in the side tray?

1. Yes, anything <0 is clammed to 0$L.
2. Yeah, side tray... I could park a freight train in the blind spot I have there.


- Kadah


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review906
-----------------------------------------------------------


On July 21, 2011, 5:34 p.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 5:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
>     http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> -------
> 
> (I had stuff here but Review Board kept deleting it every time I tried to save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110722/4eb206ea/attachment-0001.htm