[opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review917
-----------------------------------------------------------


Rejecting this fix in favor of a duplicate (but I think better) one: https://codereview.secondlife.com/r/412/


indra/newview/skins/minimal/xui/da/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment947>

    Missing rename here.



indra/newview/skins/minimal/xui/da/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment948>

    Unclear why this was removed.



indra/newview/skins/minimal/xui/es/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment949>

    missing rename



indra/newview/skins/minimal/xui/fr/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment950>

    ditto



indra/newview/skins/minimal/xui/it/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment951>

    ditto



indra/newview/skins/minimal/xui/ja/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment952>

    ditto



indra/newview/skins/minimal/xui/pl/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment953>

    ditto



indra/newview/skins/minimal/xui/pt/panel_people.xml
<http://codereview.secondlife.com/r/387/#comment954>

    ditto


- Vadim


On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 10:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
>     http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> -------
> 
> Switched to French, relogged, changed to default mode and logged out. Applied this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> Update:
> Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, fr, it, ja, pl and pt:
> Verified for each language that
> * labels on all 4 buttons on that tab are translated (or as translated as in the XML files. "IM" seems to be the wanted label for the chat button in most of them.)
> * tool-tips of all 4 buttons are translated
> * all 4 buttons cause the action they're intended to cause when clicked
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110725/48030f69/attachment-0001.htm