[opensource-dev] Review Request: OPEN-54: Making CMake variable name for JsonCpp include dir(s) consistent
Oz Linden
oz at lindenlab.com
Wed Jul 27 12:41:44 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/257/#review933
-----------------------------------------------------------
Ship it!
- Oz
On April 8, 2011, 4:41 a.m., Boroondas Gupte wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/257/
> -----------------------------------------------------------
>
> (Updated April 8, 2011, 4:41 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Chose the singular form as that seems to be what most of the Find*.cmake files use for their *_INCLUDE_DIR[S] variables.
>
>
> This addresses bug OPEN-54.
> http://jira.secondlife.com/browse/OPEN-54
>
>
> Diffs
> -----
>
> doc/contributions.txt 9ff8625cadec
> indra/cmake/JsonCpp.cmake 9ff8625cadec
> indra/newview/CMakeLists.txt 9ff8625cadec
>
> Diff: http://codereview.secondlife.com/r/257/diff
>
>
> Testing
> -------
>
> None, except for grep'ing around to make sure there's now only a single name for this.
>
>
> Thanks,
>
> Boroondas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110727/e83d43c0/attachment.htm
More information about the opensource-dev
mailing list