[opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list

[Seth ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/417/#review936
-----------------------------------------------------------

Ship it!


Looks good to me.

- Seth


On July 26, 2011, 2:02 p.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/417/
> -----------------------------------------------------------
> 
> (Updated July 26, 2011, 2:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Localized the "No Device" and "Default System Device" strings in the sound devices panel.
> 
> By the way:
> * Fixed improper localization of the "Default" device name which caused saving a localized string in settings.
> * Eliminated redundant getChild() calls.
> 
> 
> This addresses bug STORM-1405.
>     http://jira.secondlife.com/browse/STORM-1405
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 
>   indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 
>   indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/417/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/2cc5c5ac/attachment.htm