[opensource-dev] Review Request: /me emote doubles name in chat history

[ardylay at gmail.com]

> On July 28, 2011, 2:58 a.m., Boroondas Gupte wrote:
> > indra/newview/llchathistory.cpp, line 929
> > <http://codereview.secondlife.com/r/419/diff/1/?file=6814#file6814line929>
> >
> >     As you cut away a substring of the length of chat.mFrontName, I assume chat.mText contains the content of chat.mFrontName at the beginning, not "/me " or "/me'"? chat.mText doesn't seem to have been modified since (old) line 747, so I guess the comparison you removed there was nonsense, anyway?
> >     
> >     Btw., where does mFromName get added to the beginning of mText? Wouldn't it be better to not add it in the first place rather than cutting it away again here?

llviewermessage.cpp line2 3300 - 3368 is where you can find chat.mChatStyle = CHAT_STYLE_IRC;  The test I removed was occuring AFTER the /me "emote" was stripped from the message from the simulator so was ineffective.  See changeset at https://bitbucket.org/lindenlab/viewer-development/changeset/741e44af9f02 line 493.  It prepends sender name, if it exists, then removes the leading 3 characters "/me" from the message.  I did not see that display context was available at the time the name was prepended so was removed the name after context was available.  Perhaps there is a better way?


- ardy.lay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review934
-----------------------------------------------------------


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> As a resident of Second Life I find the displaying an emoter's name twice in nearby chat history rather unnecessary.  Please lay eyes on this proposed code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
>     http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -----
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> -------
> 
> Tell a crowd what you are testing and many will start talking to you prefixed with /me, if they are good sports.  I have been using this change for 3 days now and have not noticed any ill effects.  Please note: This changest is not intended to affect nearby chat toasts, nearby chat log files, IM history, IM toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110728/7ae0166f/attachment.htm