[opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

Boroondas Gupte sllists at boroon.dasgupta.ch
Fri Jul 29 02:05:50 PDT 2011



> On July 28, 2011, 6:27 p.m., ardy.lay wrote:
> > I am using it without noticing any functional issues.  Does this return floating text and nametags to a previous behavior I haven't seen for a long time?  I think it does.  It feels comfortable to me and really decluters the display.

> Does this return floating text and nametags to a previous behavior I haven't seen for a long time?
Yes, that's what it's supposed to do. See the linked SL jira issues and http://jira.phoenixviewer.com/browse/FIRE-543 (and duplicates there).


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/405/#review939
-----------------------------------------------------------


On July 21, 2011, 2:55 a.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/405/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 2:55 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Set the z (depth) coordinate of hovertext such that the hovertext gets occluded by stuff in front of it.
> 
> 
> This addresses bugs SH-489, VWR-24017 and VWR-25588.
>     http://jira.secondlife.com/browse/SH-489
>     http://jira.secondlife.com/browse/VWR-24017
>     http://jira.secondlife.com/browse/VWR-25588
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 46c7b36793c9 
>   indra/llrender/llfontgl.cpp 46c7b36793c9 
> 
> Diff: http://codereview.secondlife.com/r/405/diff
> 
> 
> Testing
> -------
> 
> Merged this change with e67da2c6e312 (as I still cannot build viewer-development tip) and rebuilt. Verified that my nametag and an objects llSetText hovertext were correctly occluded by another object in front of them.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110729/c5c519a4/attachment.htm 


More information about the opensource-dev mailing list