[opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/424/#review941
-----------------------------------------------------------



indra/llui/llspinctrl.cpp
<http://codereview.secondlife.com/r/424/#comment973>

    Put a space between '//' and the actual comment for better readability and for consistence with other comments nearby.



indra/llui/llspinctrl.cpp
<http://codereview.secondlife.com/r/424/#comment972>

    So if several modifier keys are pressed, Ctrl overrides Shift and Alt overrides Ctrl, Shift or both?
    
    (Fine with me, just want to make sure this is intended.)



indra/newview/llpanelobject.cpp
<http://codereview.secondlife.com/r/424/#comment970>

    You might want to write '0.05' instead of '1/20' in this comment.



indra/newview/llpanelobject.cpp
<http://codereview.secondlife.com/r/424/#comment971>

    Same here.


- Boroondas


On July 29, 2011, 4:40 p.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/424/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 4:40 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Adds 2 features:
> 
> Adds the ability to use modifier keys to change the defined increment on LLSpinCtrl.
> Alt: increment x10
> Ctrl: increment x0.1
> Shift: increment x0.01
> 
> Adds extra decimal places to position, size, and rotation on build floater.
> Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set smaller changes in the associated values, no change was needed for LLPanelObject::sendRotation. There should be no ill effects from this, changes are still only sent to sim on button release.
> 
> https://bitbucket.org/Kadah_Coba/storm-56
> 
> 
> This addresses bug STORM-56.
>     http://jira.secondlife.com/browse/STORM-56
> 
> 
> Diffs
> -----
> 
>   indra/llui/llspinctrl.cpp UNKNOWN 
>   indra/newview/llpanelobject.cpp UNKNOWN 
>   indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/424/diff
> 
> 
> Testing
> -------
> 
> Same code has been in use on FS beta for some time. I have built and tested this myself on v-d.
> 
> 
> Thanks,
> 
> Kadah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110730/c06052fe/attachment.htm