[opensource-dev] Review Request: Viewer cache size increase to 10GB.

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/318/#review718
-----------------------------------------------------------



indra/newview/llfloaterpreference.cpp
<http://codereview.secondlife.com/r/318/#comment685>

    I would prefer to see this done the other way (even though it produces a larger diff); test for the positive condition and enclose the resulting action in the 'then' block.
    
    I dislike early returns.  While they are sometimes justifiable in a large routine for unusual cases, I don't think this fits that bill.
    
    Not a show stopper, just a note for the future


- Oz


On June 3, 2011, 12:56 p.m., Log Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/318/
> -----------------------------------------------------------
> 
> (Updated June 3, 2011, 12:56 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This patch increases the maximum and default viewer cache size values. Due to limitations in the size of the VFS, the 80/20 texture cache/VFS split is maintained up to 5GB, then the remaining cache size is given to the texture cache. This caps the VFS size at 1GB ( up from .2 GB ).  I made corresponding changes to the XUI to allow the slider to increase to the new cache size maximum.
> 
> Bugfixes:
> * The reset cache location button will no longer tell the user that the cache will be cleared if the cache is already in the default location.  Only the notification was suppressed, the cache was never cleared by this button unless the location changed.
> * The reset cache location button will now correctly clear the old cache when it is reset back to the default location. 
> * I fixed an order of operation programming error in an llerrs log message in the lltexturecache.cpp. This was showing wildly incorrect texture cache size during a purge.
> * Code convention cleanup in llappviewer.cpp in initCache() and lltexturecache.cpp
> 
> 
> This addresses bugs er-767, er-883 and er-883.
>     http://jira.secondlife.com/browse/er-767
>     http://jira.secondlife.com/browse/er-883
>     http://jira.secondlife.com/browse/er-883
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.cpp 9c0506d10226 
>   indra/newview/llfloaterpreference.cpp 9c0506d10226 
>   indra/newview/lltexturecache.cpp 9c0506d10226 
>   indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/318/diff
> 
> 
> Testing
> -------
> 
> I have built and tested on all three platforms.  The log files indicate that the caches are being initialised with the correct sizes.
> 
> 
> Thanks,
> 
> Log
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110604/76860504/attachment-0001.htm