[opensource-dev] Review Request: VWR-25896 [Regression] Bulk uploads do not adhere to default permissions

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/323/#review720
-----------------------------------------------------------



indra/newview/llassetuploadresponders.cpp
<http://codereview.secondlife.com/r/323/#comment686>

    While you're at it, re-complete this comment that was (probably accidentally) clipped in the same commit (https://bitbucket.org/lindenlab/viewer-development/changeset/8871cfd6eaf5#chg_indra/newview/llassetuploadresponders.cpp_oldline328 )



indra/newview/llassetuploadresponders.cpp
<http://codereview.secondlife.com/r/323/#comment687>

    If the original comment is still accurate, your fix should be fine. (The now missing line in the comment explains why mPostData has to be used here rather than content.) However a lot has changed around here, so it's hard to tell whether the original comment would still apply unchanged.


- Boroondas


On June 5, 2011, 7:36 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/323/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 7:36 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Something in the big mesh branch merge (build 230088) appears to have broken bulk uploading.
> 
>     * On inventory tab, click "+" menu -> Upload -> Set Default Permissions
>     * Set your default permissions to enable Next owner Modify, Copy, and Resell/Giveaway and click OK
>     * Click "+" menu -> Upload -> Bulk and select a group of multiple images
>     * After upload completes, check permissions of each uploaded item
> 
> Expected behavior is that all the bulk uploaded items would have Modify/Copy/Transfer permissions.
> Actual results is that first item upload has Modify/Copy/Transfer permissions, all others have no perms at all.
> 
> I examined this area of code before the mesh merge and saw a small but significant difference.  It is not clear to me that this is the only change necessary; in an email Oz said a server-side change might be needed too.  
> 
> 
> This addresses bug VWR-25896.
>     http://jira.secondlife.com/browse/VWR-25896
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt e4ef43d63d55 
>   indra/newview/llassetuploadresponders.cpp e4ef43d63d55 
> 
> Diff: http://codereview.secondlife.com/r/323/diff
> 
> 
> Testing
> -------
> 
> Repeated bulk uploading of two textures, altering the settings in the bulk upload floater for each test; their uploaded properties followed the settings I had set in the floater.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110605/b8f9038c/attachment-0001.htm