[opensource-dev] Review Request: VWR-25862 Fix viewer caches not being cleared.

[Aleric Inglewood]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/315/#review724
-----------------------------------------------------------



indra/newview/llvocache.cpp
<http://codereview.secondlife.com/r/315/#comment691>

    This patch removes (everywhere, not just here) the delimiter in front of 'mask' passed to deleteFilesInDir.
    
    deleteFilesInDir does nothing with mask but pass it to LLDirIterator. Apparently, the introduction of LLDirIterator (new in Viewer 2) requires mask to NOT start with a delimiter.
    
    However, you fail to correct this consistently; for example, in LLAppViewer::migrateCacheDirectory we have the following code:
    
      std::string mask = delimiter + "*.*";
    
      LLDirIterator iter(old_cache_dir, mask);
    
    Can you explain that works (does it?) and the code that you changed didn't work?
    


- Aleric


On May 27, 2011, 1:04 p.m., Log Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/315/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 1:04 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a patch to fix the issues with clearing viewer caches documented in VWR-25862. I removed the leading delimiter in the place where each of the three caches are cleared.  I also removed the mac specific deleteFilesInDir() method, which should have been removed for STORM-477. I removed unneeded calls to getDirDelimiter() in llvocache.cpp.
> 
> 
> This addresses bugs vwr-25681 and vwr-25862.
>     http://jira.secondlife.com/browse/vwr-25681
>     http://jira.secondlife.com/browse/vwr-25862
> 
> 
> Diffs
> -----
> 
>   indra/llvfs/lldir_mac.h UNKNOWN 
>   indra/llvfs/lldir_mac.cpp UNKNOWN 
>   indra/newview/llappviewer.cpp UNKNOWN 
>   indra/newview/lltexturecache.cpp UNKNOWN 
>   indra/newview/llvocache.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/315/diff
> 
> 
> Testing
> -------
> 
> Test plan: https://jira.secondlife.com/browse/VWR-25862?#comment-262800
> 
> I built and tested on Mac, Windows and Linux and saw the correct behavior when clicking the clear history button and the move cache button.
> 
> 
> Thanks,
> 
> Log
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110606/ffec7aea/attachment.htm