[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

Altair Memo sythos at gmail.com
Mon Jun 6 12:33:15 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/#review726
-----------------------------------------------------------

Ship it!


work fine on linux, nothing "evil" visible after some time of usage.

- Altair


On May 14, 2011, 1:07 p.m., Twisted Laws wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/265/
> -----------------------------------------------------------
> 
> (Updated May 14, 2011, 1:07 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Patch makes the map in the Nearby people tab optional with a menu option in the gear 
> menu.  Patch is XML only and resizing of the map is disabled (user_resize="false" in 
> the layout_panels) as I could not find a way to easily save window sizes purely in XML.
> Patch is in the repository of https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
> and https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1
> 
> 
> This addresses bug STORM-1103.
>     http://jira.secondlife.com/browse/STORM-1103
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt ee4d271eef9b 
>   indra/newview/app_settings/settings.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 
> 
> Diff: http://codereview.secondlife.com/r/265/diff
> 
> 
> Testing
> -------
> 
> Tested by exercising the gear menu option of "View Map" with the People tab attached 
> and detached insuring the map appears and disappears properly.
> 
> 
> Thanks,
> 
> Twisted
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110606/0ea5156a/attachment.htm 


More information about the opensource-dev mailing list