[opensource-dev] Review Request: OPEN-77 Adding ability for Prebuilt.cmake to pass necessary additional options to 'autobuild install'

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/327/#review731
-----------------------------------------------------------

Ship it!


Looks good.


indra/cmake/Prebuilt.cmake
<http://codereview.secondlife.com/r/327/#comment693>

    It looks like currently, the call to autobuild install is the only call from CMake back to autobuild. If we plan to ever add more back-calls (I don't think we do nor should), we should think about whether all back-calls will take the same extra arguments. If not, better give a specific name here, like AUTOBUILD_INSTALL_EXTRA_ARGS, so they can be distinguished.


- Boroondas


On June 7, 2011, 3:17 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/327/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 3:17 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is primarily to allow the passing of '--config-file file-name' through cmake, so that 'autobuild configure' can work correctly.
> The options are passed by adding -- -DAUTOBUILD_EXTRA_ARGS:STRING=options-to-add to the end of the configure command.
> e.g. autobuild configure --config-file ab-custom.xml -c ReleaseOS -- -DAUTOBUILD_EXTRA_ARGS:STRING=--config-file=ab-custom.xml
> Thanks to Brad Linden, for most of the work.
> 
> 
> This addresses bugs OPEN-76 and OPEN-77.
>     http://jira.secondlife.com/browse/OPEN-76
>     http://jira.secondlife.com/browse/OPEN-77
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 1d4d568986e3 
>   indra/cmake/Prebuilt.cmake 1d4d568986e3 
> 
> Diff: http://codereview.secondlife.com/r/327/diff
> 
> 
> Testing
> -------
> 
> Successfully configured and built the viewer with a custom configuration and no autobuild.xml present.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110607/8e588e2f/attachment.htm