[opensource-dev] Review Request: OPEN-78 Automate the process of passing additional arguments to prebuilt.cmake

[Boroondas Gupte]

> On June 7, 2011, 5:36 p.m., Boroondas Gupte wrote:
> > autobuild/autobuild_tool_configure.py, line 69
> > <http://codereview.secondlife.com/r/331/diff/1/?file=2934#file2934line69>
> >
> >     Don't forget that file UNIX filesystems are case sensitive. Even worse, the fact that GNU make looks first for a file named 'makefile' then for one named 'Makefile' makes it common that projects ship with a 'makefile' file, and the user would then create a 'Makefile' file to override that, if wanted. That might inspire Mac/Linux users to use Autobuild.xml or some other capitalization variation for their own autobuild config file.
> >     
> >     Luckily, there's a http://docs.python.org/library/os.path.html#os.path.normcase , which does just what we want here.

meh, got GNU make's search order mixed up, but I guess you know what I mean.


- Boroondas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/331/#review732
-----------------------------------------------------------


On June 7, 2011, 3:03 p.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/331/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 3:03 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The fix in OPEN-77 allows configure to run correctly, but is cumbersome and not exactly pretty on the command line ;-)
> This fix allows autobuild itself, to automatically add the --config-file option when it determines the default (autobuild.xml) is not being used.
> 
> 
> This addresses bugs OPEN-76 and OPEN-78.
>     http://jira.secondlife.com/browse/OPEN-76
>     http://jira.secondlife.com/browse/OPEN-78
> 
> 
> Diffs
> -----
> 
>   autobuild/autobuild_tool_configure.py 2a560b1d8f95 
> 
> Diff: http://codereview.secondlife.com/r/331/diff
> 
> 
> Testing
> -------
> 
> Configure and built viewer-development with custom configuration and no default file present.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110608/9c85a46d/attachment.htm