[opensource-dev] Review Request: OPEN-76 Fix autobuild so that --config-file option is honoured by subsequent (possibly recursive) commands

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/335/#review739
-----------------------------------------------------------



autobuild/configfile.py
<http://codereview.secondlife.com/r/335/#comment699>

    I think the environment variable should be set right after this if-else block (which I think is the only place where self.path is set or modified). Otherwise the environment variable might not be set although self.path is set.
    
    ... or set the environment variable in __init__, right after the self.__load(path) call.


- Boroondas


On June 10, 2011, 1:57 a.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/335/
> -----------------------------------------------------------
> 
> (Updated June 10, 2011, 1:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> When running a command such as:
> 
> autobuild configure --config-file ab-test.xml -c ReleaseOS
> 
> the configuration is only partially completed correctly. When the installables are processed, it does not use the correct configuration file. This is due to cmake calling autobuild install to do the actual install, but not passing the --config-file option. Autobuild falls back to the default autobuild.xml, because the correct configuration file is not saved at any point, which is not the intention and can cause configuration to be done with incorrect libraries. If autobuild.xml is missing or corrupt, an error occurs (which is how I discovered this), stopping the configure command.
> 
> This fix saves the current value of the configuration file into the AUTOBUILD_CONFIG_FILE environmental variable so that it becomes the default value should any subsequent command need it. I believe that something like this was the original intention when adding this environment variable as part of the default check, but was overlooked.
> 
> 
> This addresses bug OPEN-76.
>     http://jira.secondlife.com/browse/OPEN-76
> 
> 
> Diffs
> -----
> 
>   autobuild/configfile.py 2a560b1d8f95 
> 
> Diff: http://codereview.secondlife.com/r/335/diff
> 
> 
> Testing
> -------
> 
> Ran 'autobuild configure --config-file ab-test.xml -c ReleaseOS' successfully without any errors and was able to build the expected viewer afterwards.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110610/c0707edf/attachment.htm