[opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales
Vadim ProductEngine
vsavchuk at productengine.com
Wed Jun 15 09:11:49 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/326/#review751
-----------------------------------------------------------
See minor points below.
indra/newview/llcofwearables.cpp
<http://codereview.secondlife.com/r/326/#comment709>
I suppose this can be done once in postBuild(), because the textbox only gets visible when the list is empty.
indra/newview/skins/default/xui/en/strings.xml
<http://codereview.secondlife.com/r/326/#comment710>
The section this string is in seems inappropriate.
- Vadim
On June 7, 2011, 2:32 p.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/326/
> -----------------------------------------------------------
>
> (Updated June 7, 2011, 2:32 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> 1. Launch viewer, change language to German for example.
> 2. Re-login, open COF for edit.
> 3. Open 'Attachments' accordion, delete all objects.
> ===>
> Actual: 'No attachments worn' text appears in English.
>
>
> This addresses bug STORM-899.
> http://jira.secondlife.com/browse/STORM-899
>
>
> Diffs
> -----
>
> doc/contributions.txt c0c940514b74
> indra/newview/llcofwearables.cpp c0c940514b74
> indra/newview/skins/default/xui/en/panel_cof_wearables.xml c0c940514b74
> indra/newview/skins/default/xui/en/strings.xml c0c940514b74
>
> Diff: http://codereview.secondlife.com/r/326/diff
>
>
> Testing
> -------
>
> Opened this tab with the viewer in English and also in French. I saw the same message, but that is because there is no translation for French, but it shows the call for a translation is working.
>
> What I am not sure of is if I made fix in the right way.
>
>
> Thanks,
>
> Jonathan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110615/5c57a167/attachment.htm
More information about the opensource-dev
mailing list