[opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

[Log Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/340/
-----------------------------------------------------------

(Updated June 17, 2011, 8:32 a.m.)


Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.


Changes
-------

I incorporated the feedback I got here into a new revision.

* Got rid of the hardcoded -m32 in CMakeLists.txt
* Also got rid of hard coded cmake build type
* Corrected the static library file location to lib/release
* Added the new /lib/release folder to the autobuild manifest and removed /lib
* Added the location of the other libndofdev library to the cmake warnings
* Added a BuildParam to make the built package get uploaded to the public s3

The repo is also now up on bitbucket: http://bitbucket.org/lindenlab/3p-libndofdev-linux
TC Build of this revision: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/3p-libndofdev-linux/rev/233137/arch/Linux/installer/libndofdev-0.3-linux-20110617.tar.bz2
hash: 9bf7a96c1d2fadb180fda91740c945c6

I'll put up the viewer changeset shortly as a separate diff.


Summary
-------

Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for linux.
* Added cmake build configuration.
* Added autobuild package configuration.
* Created libndofdev.txt license file from ndofdev.c file header.
* Added README to explain that this is only for use in the linux viewer.

BUGFIXES:
* OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= 2.6.33.

When reviewing, please provide extra scrutiny to autobuild.xml and CMakeLists.txt, since those are the files I actually edited.


This addresses bugs OPEN-21, STORM-1320 and STORM-312.
    http://jira.secondlife.com/browse/OPEN-21
    http://jira.secondlife.com/browse/STORM-1320
    http://jira.secondlife.com/browse/STORM-312


Diffs (updated)
-----

  BuildParams PRE-CREATION 
  autobuild.xml PRE-CREATION 
  libndofdev/CHANGELOG PRE-CREATION 
  libndofdev/CMakeLists.txt PRE-CREATION 
  libndofdev/LICENSES/libndofdev.txt PRE-CREATION 
  libndofdev/README PRE-CREATION 
  libndofdev/include/ndofdev_external.h PRE-CREATION 
  libndofdev/ndofdev.c PRE-CREATION 

Diff: http://codereview.secondlife.com/r/340/diff


Testing
-------

This built successfully on TeamCity and the packaged library worked correctly when I extracted it into the packages directory of the viewer build tree ( build-linux-i686/packages ).  My spacenavigator, which hasn't worked in six months, started working with the new build.


Thanks,

Log

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110617/e10601f0/attachment-0001.htm