[opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

Jonathan Yap jhwelch at gmail.com
Sat Jun 18 05:54:49 PDT 2011



> On June 18, 2011, 4:24 a.m., Boroondas Gupte wrote:
> > indra/newview/llbottomtray.cpp, lines 570-574
> > <http://codereview.secondlife.com/r/346/diff/1/?file=2998#file2998line570>
> >
> >     Wouldn't it be better to set the initial disabledness for all three items here in the XUI-XML with https://wiki.secondlife.com/wiki/Skinning_HowTo/Common_XUI_attributes#enabled rather than in the CPP code?
> >     
> >     (Assuming that subsequent setEnabled(voice_status) will override it in either case, so that it can still be toggled.)

Code refactoring this area is a good idea but is outside the narrow scope of this jira.  If some Linden thinks this should be done I will make the changes.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/346/#review771
-----------------------------------------------------------


On June 18, 2011, 4:12 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/346/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 4:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Add Nearby Voice to the Communicate menu.  This is currently activated via the flyout button next to the Speak button.
> 
> 
> This addresses bug STORM-1392.
>     http://jira.secondlife.com/browse/STORM-1392
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt dc5af272d23f 
>   indra/newview/llbottomtray.cpp dc5af272d23f 
>   indra/newview/skins/default/xui/en/menu_viewer.xml dc5af272d23f 
> 
> Diff: http://codereview.secondlife.com/r/346/diff
> 
> 
> Testing
> -------
> 
> Clicking menu entry toggles appearance/disappearance of Nearby Voice floater.
> 
> Noted that this menu entry is grayed out when voice is off or otherwise not available.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110618/94d117c8/attachment.htm 


More information about the opensource-dev mailing list