[opensource-dev] Review Request: Local Bitmap Browser implementation.
Boroondas Gupte
sllists at boroon.dasgupta.ch
Sat Jun 18 08:41:12 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/347/#review775
-----------------------------------------------------------
indra/newview/CMakeLists.txt
<http://codereview.secondlife.com/r/347/#comment735>
Please use 4 spaces for indentation instead of a tab, here, to be consistent with the surrounding lines.
indra/newview/CMakeLists.txt
<http://codereview.secondlife.com/r/347/#comment736>
same here
- Boroondas
On June 18, 2011, 8:04 a.m., Vaalith Jinn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/347/
> -----------------------------------------------------------
>
> (Updated June 18, 2011, 8:04 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> -------
>
> Local Bitmap Browser is a mechanism to locally load images into the viewer, track them and optionally (per each image)
> have it check if the image has been overwritten locally and if so - update it in the viewer and inworld.
>
> This change affects build menu by adding a way to open the floater there.
> This change also affects the texture picker - adding tabs that lets the user choose between the "Server" (regular inventory) and "Local" tabs (list of locally added files).
>
>
> This addresses bug STORM-64.
> http://jira.secondlife.com/browse/STORM-64
>
>
> Diffs
> -----
>
> doc/contributions.txt 6a3e7e403bd1
> indra/llmath/llvolumemgr.h 6a3e7e403bd1
> indra/llmath/llvolumemgr.cpp 6a3e7e403bd1
> indra/newview/CMakeLists.txt 6a3e7e403bd1
> indra/newview/llfloaterlocalbitmap.h PRE-CREATION
> indra/newview/llfloaterlocalbitmap.cpp PRE-CREATION
> indra/newview/lltexturectrl.h 6a3e7e403bd1
> indra/newview/lltexturectrl.cpp 6a3e7e403bd1
> indra/newview/llviewerfloaterreg.cpp 6a3e7e403bd1
> indra/newview/llviewerobjectlist.h 6a3e7e403bd1
> indra/newview/llviewertexturelist.h 6a3e7e403bd1
> indra/newview/llvovolume.h 6a3e7e403bd1
> indra/newview/skins/default/xui/en/floater_local_bitmap.xml PRE-CREATION
> indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 6a3e7e403bd1
> indra/newview/skins/default/xui/en/menu_viewer.xml 6a3e7e403bd1
>
> Diff: http://codereview.secondlife.com/r/347/diff
>
>
> Testing
> -------
>
> Texture/Sculptmap/Avatar Layer show.
> Texture/Sculptmap/Avatar Layer update.
> Multiple sculpties update.
> Opening multiple browser floaters works correctly. (two possible since one can be opened from menu above, one from texture picker. all of them + texture picker play nice.)
> Tested adding over 200 images at the same time.
>
>
> Thanks,
>
> Vaalith
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110618/1b94fb12/attachment.htm
More information about the opensource-dev
mailing list