[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review778
-----------------------------------------------------------


Seems to work for me, although I'd appreciate if you used a more straightforward (=less error prone) logic.


indra/newview/llvoicevivox.cpp
<http://codereview.secondlife.com/r/333/#comment740>

    Inconsistent spacing around "if" conditions.
    
    Please use "if (cond)" with no extra or missing spaces.
    
    This also applies to other changes in the patch.



indra/newview/llvoicevivox.cpp
<http://codereview.secondlife.com/r/333/#comment741>

    It's unclear to me why you set voice to enabled here.
    I think it should be set to enabled only when we're sure the parcel supports it.



indra/newview/llvoicevivox.cpp
<http://codereview.secondlife.com/r/333/#comment739>

    What if region caps never arrive?
    The string may grow infinitely.
    
    Also I don't like using region name as a marked that region caps haven't arrived yet -- that's a hack.



indra/newview/llvoicevivox.cpp
<http://codereview.secondlife.com/r/333/#comment738>

    This could be written shorter:
    mRegionHasVoice = enabled;


- Vadim


On June 9, 2011, 9:56 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 9:56 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed this fix along in the system.
> 
> ----
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that rezzes in, but the avatar, so do the request for the capability not earlier than the agents region signals capabilitiesReceived() true. After that you are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not much data transmitted, though its a pretty big number of people doing it over and over per second (no matter if they have voice on or off).
> 
> 
> ----
> 
> going once again through llviewerregion I see its fortunately not each time a HTTP GET, just once when the agent connects to the region. Though the patch still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
>     http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/newview/llvoicevivox.h a36a329e77cc 
>   indra/newview/llvoicevivox.cpp a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110620/cde4e5ce/attachment.htm