[opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/341/
-----------------------------------------------------------

(Updated June 20, 2011, 3:29 p.m.)


Review request for Viewer.


Changes
-------

Issue a warning if a NULL chat toast is encountered.

I'm not doing that in the sort functor to make sure we print only one warning per invalid item.


Summary
-------

Apparently, a nearby chat toast got somehow destroyed while still remaining in the list of active toasts.
Attempt to sort active toasts in showToastsBottom() then triggered the crash.

I don't know how to reproduce the crash, i.e. force destroying a toast in a way that its onClose() method (which would remove references to the toast) isn't called.
So we'll just remove references to the toast whenever it's destroyed.


This addresses bug STORM-1352.
    http://jira.secondlife.com/browse/STORM-1352


Diffs (updated)
-----

  indra/newview/llnearbychathandler.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/341/diff


Testing
-------


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110620/6b148eba/attachment.htm