[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

ArminWeatherHax Resident armin.weatherwax at googlemail.com
Tue Jun 21 10:33:35 PDT 2011



> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote:
> > indra/newview/llvoicevivox.cpp, lines 4485-4488
> > <http://codereview.secondlife.com/r/333/diff/1/?file=2939#file2939line4485>
> >
> >     What if region caps never arrive?
> >     The string may grow infinitely.
> >     
> >     Also I don't like using region name as a marked that region caps haven't arrived yet -- that's a hack.
> 
> ArminWeatherHax Resident wrote:
>     The state engine resets the string if it was changed, but you are right, it's not nice. I'll go for adding LLVivoxVoiceClient::parcelChanged() to LLViewerParcelMgr::addAgentParcelChangedCallback which will make the whole patch more straightforward.
> 
> Vadim ProductEngine wrote:
>     Sounds good.
>     
>     BTW, while working on Windlight Region Settings I added a "capabilities received" signal in LLViewerRegion, which might be of use here as well. That code hasn't been integrated yet, but if you want I can send you the patch.

Currently I have a new state which rechecks capabilitiesReceived until true,  and was about to add a comment to it that a callback would be much better - so yes please about sending that patch :) 


> On June 20, 2011, 9:49 a.m., Vadim ProductEngine wrote:
> > indra/newview/llvoicevivox.cpp, line 557
> > <http://codereview.secondlife.com/r/333/diff/1/?file=2939#file2939line557>
> >
> >     Inconsistent spacing around "if" conditions.
> >     
> >     Please use "if (cond)" with no extra or missing spaces.
> >     
> >     This also applies to other changes in the patch.

"if[space](cond)" - is that right?


- ArminWeatherHax


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review778
-----------------------------------------------------------


On June 9, 2011, 9:56 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 9:56 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed this fix along in the system.
> 
> ----
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that rezzes in, but the avatar, so do the request for the capability not earlier than the agents region signals capabilitiesReceived() true. After that you are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not much data transmitted, though its a pretty big number of people doing it over and over per second (no matter if they have voice on or off).
> 
> 
> ----
> 
> going once again through llviewerregion I see its fortunately not each time a HTTP GET, just once when the agent connects to the region. Though the patch still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
>     http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/newview/llvoicevivox.h a36a329e77cc 
>   indra/newview/llvoicevivox.cpp a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110621/f95c224e/attachment.htm 


More information about the opensource-dev mailing list