[opensource-dev] Review Request: Check for null ptr to hopefully prevent crash in LLToolPie

Vadim ProductEngine vsavchuk at productengine.com
Tue Jun 21 10:35:08 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/359/#review800
-----------------------------------------------------------

Ship it!


The check certainly will not hurt.

- Vadim


On June 21, 2011, 8:53 a.m., Alain Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/359/
> -----------------------------------------------------------
> 
> (Updated June 21, 2011, 8:53 a.m.)
> 
> 
> Review request for Viewer, Oz Linden and Vadim ProductEngine.
> 
> 
> Summary
> -------
> 
> checking for null gAgentAvatarp should hopefully prevent the crash.  I can't reproduce it so I don't know for sure.
> 
> 
> This addresses bug EXP-825.
>     http://jira.secondlife.com/browse/EXP-825
> 
> 
> Diffs
> -----
> 
>   indra/newview/lltoolpie.cpp e8f2a53c3d6e 
> 
> Diff: http://codereview.secondlife.com/r/359/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110621/cd214b21/attachment.htm 


More information about the opensource-dev mailing list