[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/
-----------------------------------------------------------

(Updated June 26, 2011, 8:32 a.m.)


Review request for Viewer.


Changes
-------

Corrects an issue identified in JIRA STORM-1103 where it is possible to make it so the map can no longer be displayed.
Quoted from JIRA

 1. Open Nearby Panel
 2. Decrease viewer window height until mini-map disappears automatically
 3. Disable mini-map in the gear menu
 4. Maximize viewer window height
 5. Enable minim-map via gear menu

Actual Results Minimap isn't displayed without this patch.  With this patch, the Minimap is still displayable.


Summary
-------

Patch makes the map in the Nearby people tab optional with a menu option in the gear 
menu.  Patch is XML only and resizing of the map is disabled (user_resize="false" in 
the layout_panels) as I could not find a way to easily save window sizes purely in XML.
Patch is in the repository of https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
and https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1


This addresses bug STORM-1103.
    http://jira.secondlife.com/browse/STORM-1103


Diffs (updated)
-----

  indra/newview/skins/default/xui/en/panel_people.xml 48b66643a4d1 

Diff: http://codereview.secondlife.com/r/265/diff


Testing
-------

Tested by exercising the gear menu option of "View Map" with the People tab attached 
and detached insuring the map appears and disappears properly.


Thanks,

Twisted

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110626/af1552ec/attachment.htm