[opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Oz Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review824
-----------------------------------------------------------


Just a couple of minor items to address and this looks good.


remove the 'KC:' from your comments ... mercurial will tell us who to blame if we need to know :-)
I don't really think that the issue ids are needed either, but don't object to them.


indra/newview/llpanelpermissions.h
<http://codereview.secondlife.com/r/365/#comment831>

    it would be clearer to spell that 'mLastSelectedObject' (transpose 'j' and 'e')



indra/newview/llpanelpermissions.cpp
<http://codereview.secondlife.com/r/365/#comment832>

    There's nothing else inside this 'else if' - why not add the check of update_sale_info to this statement rather than adding the nested if ?


- Oz


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> This change makes it so setting an object for sale or modifying the price or sale type requires explicitly applying the changes. Default behavior before this patch is all sale info is committed to sim on change. After this patch the sale info will only get set or modified after hitting a "mark for sale" button. There is no change to removing an object from sale, unchecking "For sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
>     http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -----
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> -------
> 
> (I had stuff here but Review Board kept deleting it every time I tried to save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110629/77afa5a6/attachment.htm