[opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields
Kadah Coba
kadah.coba at gmail.com
Thu Jun 30 13:50:22 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
-----------------------------------------------------------
(Updated June 30, 2011, 1:50 p.m.)
Review request for Viewer.
Changes
-------
I have no idea why review board keeps breaking my diffs. Trying again.
Summary
-------
This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X".
Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3.
Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315
Diffs (updated)
-----
doc/contributions.txt 353807ed6a69
indra/llmath/CMakeLists.txt 353807ed6a69
indra/llmath/llcalc.h PRE-CREATION
indra/llmath/llcalc.cpp PRE-CREATION
indra/llmath/llcalcparser.h PRE-CREATION
indra/llmath/llcalcparser.cpp PRE-CREATION
indra/llui/lllineeditor.h 353807ed6a69
indra/llui/lllineeditor.cpp 353807ed6a69
indra/llui/llspinctrl.cpp 353807ed6a69
indra/newview/llappviewer.cpp 353807ed6a69
indra/newview/llpanelface.cpp 353807ed6a69
indra/newview/llpanelobject.cpp 353807ed6a69
Diff: http://codereview.secondlife.com/r/377/diff
Testing
-------
Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed.
Thanks,
Kadah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110630/c413a922/attachment.htm
More information about the opensource-dev
mailing list