[opensource-dev] Review Request: VWR-24957: Attachments may loose their associated inventory item UUID

Merov Linden merov at lindenlab.com
Tue Mar 1 18:51:33 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/161/#review400
-----------------------------------------------------------

Ship it!


Seems correct to me.

- Merov


On Feb. 22, 2011, 4:49 a.m., Kitty Barnett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/161/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 4:49 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Current flow:
> 1) object->extractAttachmentItemID()
> 2) "same object reattached" condition evaluates true => removeObject calls object->setAttachmentItemID(LLUUID::null)
> 3) the remainder of addObject() executes but the object's mAttachmentItemID is now "LLUUID::null"
> 
> Reversing the order of (1) and (2) should prevent mAttachmentItemID from being - in this specific case accidentally - cleared
> 
> 
> This addresses bug VWR-24957.
>     http://jira.secondlife.com/browse/VWR-24957
> 
> 
> Diffs
> -----
> 
>   indra/newview/llviewerjointattachment.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/161/diff
> 
> 
> Testing
> -------
> 
> I can't trigger that block for my avie's attachments "on demand" but I actually made this change a while back (before SVC-6766) in response to reports from users and this was the only possibility I could find in the viewer where an attachment may suddenly "forget" its associated inventory item.
> 
> 
> Thanks,
> 
> Kitty
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110302/3090f477/attachment.htm 


More information about the opensource-dev mailing list