[opensource-dev] Review Request: on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory

Merov Linden merov at lindenlab.com
Tue Mar 1 22:14:13 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/168/#review403
-----------------------------------------------------------

Ship it!


Seems good to me.

- Merov


On Feb. 26, 2011, 1:38 p.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/168/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2011, 1:38 p.m.)
> 
> 
> Review request for Viewer and Aleric Inglewood.
> 
> 
> Summary
> -------
> 
> On standalone, -I"${TUT_INCLUDE_DIR}" was added to the compile flags for integration tests of llcommon when TUT_INCLUDE_DIR might not have been set yet. This lead to a flag -I"", which would confuse g++ and lead to the tests' object files not being found.
> 
> This change makes sure that TUT_INCLUDE_DIR is set by including Tut.cmake, which is responsible for setting it.
> 
> 
> This addresses bug OPEN-39.
>     http://jira.secondlife.com/browse/OPEN-39
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 1013caf84c2e 
>   indra/cmake/LLAddBuildTest.cmake 1013caf84c2e 
> 
> Diff: http://codereview.secondlife.com/r/168/diff
> 
> 
> Testing
> -------
> 
> Clean rebuild with LL_TESTS ON (see also repro instructions on jira)
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110302/5e66d1ba/attachment.htm 


More information about the opensource-dev mailing list