[opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

[Seth ProductEngine]

> On March 3, 2011, 11:45 a.m., Richard Nelson wrote:
> > indra/llui/lltextbase.cpp, line 604
> > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line604>
> >
> >     this will still display views that are partially outside of the visible rect
> >     
> >     what you want to do iscall mDocumentView->draw() inside the block that has the clip operation and then hide the mDocumentView when calling LLUICtrl::draw.
> >     
> >

The clip rect in the block with drawText() call is not enabled for the editors without a scroller and even enabling it and calling mDocumentView->draw() inside that block cuts off the bottom of the last visible line of text (see screenshot at https://jira.secondlife.com/secure/attachment/48565/clipped_text.png).

With allow_scroll="false" & clip_partial="true" settings for the editor we lose one text line and if there are icons on the first line they will be clipped anyway because the top of such icons exceeds the top limit of the visible rect.


- Seth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review409
-----------------------------------------------------------


On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/169/
> -----------------------------------------------------------
> 
> (Updated March 1, 2011, 1:53 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed text editor to display the embedded widgets only if they are in the currently visible area of a text document.
> 
> 
> This addresses bug STORM-721.
>     http://jira.secondlife.com/browse/STORM-721
> 
> 
> Diffs
> -----
> 
>   indra/llui/lltextbase.cpp 767feb16f05f 
> 
> Diff: http://codereview.secondlife.com/r/169/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110303/a9a37114/attachment.htm