[opensource-dev] Review Request: STORM-236 Allow the "Speak" button to be removed, like other buttons

[Vadim ProductEngine]

> On March 3, 2011, 5:42 p.m., Wolfpup Lowenhar wrote:
> > I built the repository provided in the JIRA locally and have tested this on my system works for Windows 7 32-bit. There is still an intermittent spacing issue that corrects itself if you cycle Voice when the Speak Button is not next to the chat panel.

How to reproduce this issue?


> On March 3, 2011, 5:42 p.m., Wolfpup Lowenhar wrote:
> > indra/newview/llbottomtray.h, line 119
> > <http://codereview.secondlife.com/r/170/diff/1/?file=1021#file1021line119>
> >
> >     bool instead of BOOL? (code consistence)

The coding standard advices using bool rather than BOOL.


> On March 3, 2011, 5:42 p.m., Wolfpup Lowenhar wrote:
> > indra/newview/llbottomtray.cpp, line 1596
> > <http://codereview.secondlife.com/r/170/diff/1/?file=1022#file1022line1596>
> >
> >     Documentation ?

Again, nothing to document, eliminating code duplication.


> On March 3, 2011, 5:42 p.m., Wolfpup Lowenhar wrote:
> > indra/newview/llbottomtray.cpp, line 799
> > <http://codereview.secondlife.com/r/170/diff/1/?file=1022#file1022line799>
> >
> >     Document?

Nothing to document here, I just moved duplicated code to a method.
See diff v2 in which I addressed all such cases.


> On March 3, 2011, 5:42 p.m., Wolfpup Lowenhar wrote:
> > indra/newview/llbottomtray.cpp, lines 1731-1741
> > <http://codereview.secondlife.com/r/170/diff/1/?file=1022#file1022line1731>
> >
> >     This looks good but would help if there was some documentation here explaining this function and exactly why it is needed.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/170/#review415
-----------------------------------------------------------


On March 3, 2011, 10:33 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/170/
> -----------------------------------------------------------
> 
> (Updated March 3, 2011, 10:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Cumulative diff of changes made by Wolfpup, Richard and me.
> 
> Description:
> * Ability to hide the Speak button with the bottom tray context menu.
> * Made the chat input resize handle visible, so that the feature is easily discoverable.
> * Applied Richard's fix to layout panel resizing logic.
> 
> My changes:
> * Made the Speak button inhibit auto-hiding (that is its original behavior).
>   This also fixes numerous glitches with buttons resizing/positioning.
> * Fixed resize cursor drawn on a non-Speak button to the right of the chat input.
> * Reverted wrong changes to LLSpeakButton class:
>   - The correct way to hide a button is either removing it from the parent's child list
>     or calling button->setVisible(FALSE).
>   - There was no need to narrow the speaking indicator.
> * Moved the drag handle icon file to icons/bottomtray/ folder.
> * Cleanups.
> 
> 
> This addresses bug STORM-236.
>     http://jira.secondlife.com/browse/STORM-236
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 767feb16f05f 
>   indra/llui/lllayoutstack.cpp 767feb16f05f 
>   indra/newview/llbottomtray.h 767feb16f05f 
>   indra/newview/llbottomtray.cpp 767feb16f05f 
>   indra/newview/skins/default/textures/bottomtray/ChatBarHandle.png 767feb16f05f 
>   indra/newview/skins/default/textures/textures.xml 767feb16f05f 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml 767feb16f05f 
>   indra/newview/skins/default/xui/en/panel_bottomtray.xml 767feb16f05f 
> 
> Diff: http://codereview.secondlife.com/r/170/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110304/2997aa32/attachment.htm