[opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

Boroondas Gupte sllists at boroon.dasgupta.ch
Mon Mar 7 16:44:21 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Searched all uses of the copy_if_different CMake macro, and where variables were passed as arguments, double-quoted them.


This addresses bug OPEN-36.
    http://jira.secondlife.com/browse/OPEN-36


Diffs
-----

  indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
  indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
  indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 

Diff: http://codereview.secondlife.com/r/182/diff


Testing
-------

Successfully configured with
autobuild configure -c OpenSourceStandAloneRelWithDebInfo

(Building still fails due to unrelated issues.)


Thanks,

Boroondas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110308/0f1ca877/attachment.htm 


More information about the opensource-dev mailing list