[opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

Boroondas Gupte sllists at boroon.dasgupta.ch
Tue Mar 8 19:15:43 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/#review436
-----------------------------------------------------------


Discarding my fix, as I didn't properly investigate the situation. See my comment at https://jira.secondlife.com/browse/OPEN-36?focusedCommentId=247669&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-247669

- Boroondas


On March 7, 2011, 4:44 p.m., Boroondas Gupte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/182/
> -----------------------------------------------------------
> 
> (Updated March 7, 2011, 4:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Searched all uses of the copy_if_different CMake macro, and where variables were passed as arguments, double-quoted them.
> 
> 
> This addresses bug OPEN-36.
>     http://jira.secondlife.com/browse/OPEN-36
> 
> 
> Diffs
> -----
> 
>   indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
>   indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
>   indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 
> 
> Diff: http://codereview.secondlife.com/r/182/diff
> 
> 
> Testing
> -------
> 
> Successfully configured with
> autobuild configure -c OpenSourceStandAloneRelWithDebInfo
> 
> (Building still fails due to unrelated issues.)
> 
> 
> Thanks,
> 
> Boroondas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110309/889a6d64/attachment-0001.htm 


More information about the opensource-dev mailing list