[opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

[Twisted Laws]

> On March 10, 2011, 2:57 p.m., Jonathan Yap wrote:
> > indra/newview/llnetmap.cpp, line 514
> > <http://codereview.secondlife.com/r/133/diff/1/?file=767#file767line514>
> >
> >     Why is a 0 (or in some other places of the code, a NULL) being passed here?  It seems the definition of isTracking() does nothing with this and it could be eliminated from the definition in the .h file and the code that calls it.

it would have been beyond the scope of the change to have modified that.  just following the style of existing code.


- Twisted


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/#review442
-----------------------------------------------------------


On Feb. 3, 2011, 12:43 p.m., Twisted Laws wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/133/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 12:43 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Sets "Stop Tracking" enabled based on tracking if true or false instead of only when true.  Also made it check for menu pointer validity to remove a remote crash possiblity.
> 
> 
> This addresses bug STORM-971.
>     http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -----
> 
>   indra/newview/llnetmap.cpp ec4a9fd30688 
> 
> Diff: http://codereview.secondlife.com/r/133/diff
> 
> 
> Testing
> -------
> 
> My testing was to open the side panel nearby, and verify that the state of the menu was correct when tracking by the different methods and disabled.   Then leaving that open, openned a mini-map instance and repeated testing its state tracking and not.  Also tried the reverse. Verified that every possibility I could think of, the state of both menus was always correct.  
> 
> Correct state is Stop Tracking is enabled anytime tracking is on for avatars or landmarks and is not enabled when Tracking has been stopped no matter where you stopped tracking (i.e, clicking on red arrow in view window, and using the various menues).
> 
> 
> Thanks,
> 
> Twisted
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110310/a09f934f/attachment.htm