[opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

Vadim ProductEngine vsavchuk at productengine.com
Mon Mar 14 11:06:18 PDT 2011



> On March 14, 2011, 8:53 a.m., Twisted Laws wrote:
> > This looks good to me and I've already made most of these changes in my own 
> > viewer as it makes the mini-map control be more useful and able to be used 
> > more places.  One additional change I'd recommend is in llNetMap::handleMouseDown
> > or you may not be able to drag the true mini-map floater around the screen.
> > This is to only return TRUE (or handled) when the mini-map control really is
> > handling the call.
> > 
> > BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
> > {
> > 	BOOL ret = FALSE;
> > 	if (mask & MASK_SHIFT)
> > 	{
> > 		// Start panning
> > 		gFocusMgr.setMouseCapture(this);
> > 
> > 		mStartPan = mCurPan;
> > 		ret = TRUE;
> > 	}
> > 	mMouseDown.mX = x;
> > 	mMouseDown.mY = y;
> > 	return ret;
> > }
> >

Twisted, I fail to see any dragging problrem with the mini-map floater. Are you sure this change is needed?


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
-----------------------------------------------------------


On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> -----------------------------------------------------------
> 
> (Updated March 14, 2011, 8:44 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
>   that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
>   out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
>   (BOOL is known to cause hard-to-debug side effects with values > 1
>   because it's essentially just an int and thus doesn't enforce
>   any limitations on the value).
> 
> Originally based on the patch by Twisted Laws: https://codereview.secondlife.com/r/133/
> 
> 
> This addresses bug STORM-971.
>     http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatermap.h 439fc3a274d8 
>   indra/newview/llfloatermap.cpp 439fc3a274d8 
>   indra/newview/llnetmap.cpp 439fc3a274d8 
>   indra/newview/lltracker.h 439fc3a274d8 
> 
> Diff: http://codereview.secondlife.com/r/200/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110314/362a99ac/attachment.htm 


More information about the opensource-dev mailing list