[opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

[Twisted Laws]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review461
-----------------------------------------------------------

Ship it!


Looks excellent!

- Twisted


On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> -----------------------------------------------------------
> 
> (Updated March 14, 2011, 8:44 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
>   that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
>   out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
>   (BOOL is known to cause hard-to-debug side effects with values > 1
>   because it's essentially just an int and thus doesn't enforce
>   any limitations on the value).
> 
> Originally based on the patch by Twisted Laws: https://codereview.secondlife.com/r/133/
> 
> 
> This addresses bug STORM-971.
>     http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -----
> 
>   indra/newview/llfloatermap.h 439fc3a274d8 
>   indra/newview/llfloatermap.cpp 439fc3a274d8 
>   indra/newview/llnetmap.cpp 439fc3a274d8 
>   indra/newview/lltracker.h 439fc3a274d8 
> 
> Diff: http://codereview.secondlife.com/r/200/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vadim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110314/b0080fa2/attachment.htm