[opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

Boroondas Gupte sllists at boroon.dasgupta.ch
Wed Mar 16 19:20:22 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review470
-----------------------------------------------------------


You're welcome, and thank you, too. :-)


indra/newview/llexpandabletextbox.h
<http://codereview.secondlife.com/r/198/#comment350>

    Even if the name of the method is now more descriptive, its doxygen documentation should provide at least as much or even more information.
    
    Maybe 'Shows the "More" link if the text is too high to be completely visible without expanding the text box. Hides that link otherwise.'
    
    ( Inspired by both versions of this comment: )



indra/newview/llexpandabletextbox.cpp
<http://codereview.secondlife.com/r/198/#comment351>

    



indra/newview/llexpandabletextbox.cpp
<http://codereview.secondlife.com/r/198/#comment348>

    The comments speak of a '"More" link' and a 'expander', but never mention that those terms actually mean the same thing. (Or that one is an example for the other, or whatever the case is.)
    
    Appending 'a.k.a. "More" link' after the word 'expander' on line 198 would probably be sufficient to hint at the relationship.


- Boroondas


On March 16, 2011, 5:19 p.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/198/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 5:19 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed "More" link being toggled in expandable textbox after reshaping.
> 
> 
> This addresses bug STORM-250.
>     http://jira.secondlife.com/browse/STORM-250
> 
> 
> Diffs
> -----
> 
>   indra/newview/llexpandabletextbox.h b761ed94eb26 
>   indra/newview/llexpandabletextbox.cpp b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/198/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110317/2ba4b171/attachment.htm 


More information about the opensource-dev mailing list