[opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

Alain Linden alain at lindenlab.com
Thu Mar 17 09:22:22 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/213/#review476
-----------------------------------------------------------


I don't like leaking these details into the executable interface.  I'd prefer to do this another way, but I'll have to think about precisely what that way is.

- Alain


On March 16, 2011, 8:19 p.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/213/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 8:19 p.m.)
> 
> 
> Review request for Viewer and Alain Linden.
> 
> 
> Summary
> -------
> 
> Extended the __call__ method of Executable to pass in the command type as a string and the dry_run flag so that the logging of the command being run could use the infrastructure there to exactly assemble the options and arguments for the logging of the command to be run.  The callers then don't need to do the logging separately or do anything with dry_run other than pass it down to the executable.
> 
> 
> This addresses bug open-45.
>     http://jira.secondlife.com/browse/open-45
> 
> 
> Diffs
> -----
> 
>   autobuild/autobuild_tool_build.py abc1014d5ad6 
>   autobuild/autobuild_tool_configure.py abc1014d5ad6 
>   autobuild/executable.py abc1014d5ad6 
> 
> Diff: http://codereview.secondlife.com/r/213/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110317/da41c0f3/attachment.htm 


More information about the opensource-dev mailing list