[opensource-dev] Review Request: Suggested fix for OPEN-45

Oz Linden oz at lindenlab.com
Thu Mar 17 17:05:07 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/215/#review485
-----------------------------------------------------------

Ship it!


Even better than my solution

- Oz


On March 17, 2011, 3:02 p.m., Alain Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/215/
> -----------------------------------------------------------
> 
> (Updated March 17, 2011, 3:02 p.m.)
> 
> 
> Review request for Viewer, Oz Linden and Boroondas Gupte.
> 
> 
> Summary
> -------
> 
> Suggested fix for OPEN-45.  I'd like to decouple Executable as much as possible from assumptions and state of autobuild.  To that end I added an optional argument to the __str__ method to accept an options list to insert into the command string.  The command string generated by __call__ and __str__ is now identical.  Incidentally I made the environment an optional argument to __call__ to make it more general and decouple it a little more from the rest of autobuild.
> 
> 
> This addresses bug OPEN-45.
>     http://jira.secondlife.com/browse/OPEN-45
> 
> 
> Diffs
> -----
> 
>   autobuild/autobuild_tool_build.py abc1014d5ad6 
>   autobuild/autobuild_tool_configure.py abc1014d5ad6 
>   autobuild/common.py abc1014d5ad6 
>   autobuild/executable.py abc1014d5ad6 
> 
> Diff: http://codereview.secondlife.com/r/215/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110318/6fa23630/attachment-0001.htm 


More information about the opensource-dev mailing list