[opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

Seth ProductEngine slitovchuk at productengine.com
Fri Mar 18 13:39:52 PDT 2011



> On March 3, 2011, 11:45 a.m., Richard Nelson wrote:
> > indra/llui/lltextbase.cpp, line 604
> > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line604>
> >
> >     this will still display views that are partially outside of the visible rect
> >     
> >     what you want to do iscall mDocumentView->draw() inside the block that has the clip operation and then hide the mDocumentView when calling LLUICtrl::draw.
> >     
> >
> 
> Seth ProductEngine wrote:
>     The clip rect in the block with drawText() call is not enabled for the editors without a scroller and even enabling it and calling mDocumentView->draw() inside that block cuts off the bottom of the last visible line of text (see screenshot at https://jira.secondlife.com/secure/attachment/48565/clipped_text.png).
>     
>     With allow_scroll="false" & clip_partial="true" settings for the editor we lose one text line and if there are icons on the first line they will be clipped anyway because the top of such icons exceeds the top limit of the visible rect.
> 
> Richard Nelson wrote:
>     With allow_scroll="false" and clip_partial="true", you shouldn't lose a line of text, so that sounds like the bug to fix.  If icons on the first line are being clipped, you could increase the v_pad attribute to leave enough room, although the size of the icon should be accounted for in the text layout, so that is either another bug or related to the first bug above.
>     
>     I'd strongly suggest fixing those issues instead of using your proposed fix.  Visibility of the text and widgets embedded within the text should be handled in the same way if possible.
>     
>     I'll let you know if I find any obvious source of these problems.
>     
>

Applying clip_partial="true" does not clip the icons on the first line but clips the last line in case with the particular "user_details" textbox in avatar inspector because its height is less than the height of three text lines, but I think this is how "clip_partial" is supposed too work, so it's not a bug.

It is the clip rect in LLTextBase::draw() that cuts the icons in the first line because they exceed the document view rect if no positive v_pad is applied.

So I'm waiting for your fix. Thanks!


- Seth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review409
-----------------------------------------------------------


On March 4, 2011, 10:30 a.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/169/
> -----------------------------------------------------------
> 
> (Updated March 4, 2011, 10:30 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Fixed text editor to display the embedded widgets only if they are in the currently visible area of a text document.
> 
> 
> This addresses bug STORM-721.
>     http://jira.secondlife.com/browse/STORM-721
> 
> 
> Diffs
> -----
> 
>   indra/llui/lltextbase.cpp 767feb16f05f 
> 
> Diff: http://codereview.secondlife.com/r/169/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110318/e48d6f45/attachment.htm 


More information about the opensource-dev mailing list