[opensource-dev] Review Request: STORM-323: redundant popups

Boroondas Gupte sllists at boroon.dasgupta.ch
Thu Mar 24 06:01:09 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/230/#review495
-----------------------------------------------------------

Ship it!


Looks good.

Not your fault, but I can't resist to mention the ...


indra/newview/llviewermessage.cpp
<http://codereview.secondlife.com/r/230/#comment362>

    ... exact (apart from indentation level) ...



indra/newview/llviewermessage.cpp
<http://codereview.secondlife.com/r/230/#comment363>

    ... code duplication.


- Boroondas


On March 24, 2011, 4:34 a.m., Lance Corrimal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/230/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 4:34 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Fixed the redundant "You have accepted suchandsuch from soandso" popups that had to actually be confirmed by clicking OK by changing the popup type to SystemMessageTip.
> 
> 
> This addresses bug storm-323.
>     http://jira.secondlife.com/browse/storm-323
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 580ef56f84bd 
>   indra/newview/llviewermessage.cpp 580ef56f84bd 
> 
> Diff: http://codereview.secondlife.com/r/230/diff
> 
> 
> Testing
> -------
> 
> I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does that count as testing? ;)
> 
> 
> Thanks,
> 
> Lance
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110324/3bcbaf6d/attachment.htm 


More information about the opensource-dev mailing list