[opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

[Vadim ProductEngine]

> On March 24, 2011, 6:04 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/notifications.xml, line 6616
> > <http://codereview.secondlife.com/r/229/diff/1/?file=1319#file1319line6616>
> >
> >     I guess you meant that *voice* is enabled by default, not microphone.
> >     
> >     Mic only gets enabled explicitly by pressing the Speak button or middle mouse button.
> 
> Jonathan Yap wrote:
>     My message about the mic being on by default is correct.  I asked Q about this and he said it was a design decision.  Every new user has their mic on when they first start the viewer.  Then they wonder why no one writes back when they are using text chat; they have been muted.
>     
>     See the xml code block that shows the mic is on by default in one of my jira comments for this issue.

Right, it says "EnableVoiceChat". This is not the same as "enable microphone".
The difference is that you can have voice chat enabled and thus hear others speak, but your mic will be off until you press Speak.

I tried wiping my Second Life settings (emulating first run) and made sure that by default voice chat is enabled while mic isn't.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review496
-----------------------------------------------------------


On March 23, 2011, 6:06 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> -----------------------------------------------------------
> 
> (Updated March 23, 2011, 6:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time you use the viewer, have voice on (the default), and successfully connect to a voice server.
> 
> 
> This addresses bug STORM-1077.
>     http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt b761ed94eb26 
>   indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 
>   indra/newview/llbottomtray.cpp b761ed94eb26 
>   indra/newview/llfirstuse.h b761ed94eb26 
>   indra/newview/llfirstuse.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110324/62f786af/attachment.htm