[opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

Vadim ProductEngine vsavchuk at productengine.com
Thu Mar 24 09:29:55 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review499
-----------------------------------------------------------


Looks good now. I only have one question, see below.


indra/newview/llcallfloater.cpp
<http://codereview.secondlife.com/r/229/#comment367>

    redundant change



indra/newview/llspeakbutton.cpp
<http://codereview.secondlife.com/r/229/#comment368>

    Why do you do this again on mouse up as well?
    Isn't it enough to dismiss the hint on mouse down only?


- Vadim


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time you use the viewer, have voice on (the default), and successfully connect to a voice server.
> 
> 
> This addresses bug STORM-1077.
>     http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -----
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110324/22bd1c4d/attachment-0001.htm 


More information about the opensource-dev mailing list