[opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"

Jonathan Yap jhwelch at gmail.com
Thu Mar 24 11:04:40 PDT 2011



> On March 24, 2011, 11:04 a.m., Jonathan Yap wrote:
> > I deleted the line in the mouse-up speak button code that turns off the speak button hint.  That line was there when I incorrectly though the speak button might be on at viewer startup.  I could not get the diff to update so am commenting in here.

You can look at the bitbucket repo to see the change.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/229/#review500
-----------------------------------------------------------


On March 24, 2011, 9:10 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/229/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 9:10 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> 1) Change Voice Enabled to Speak Button when you right click on the bottom bar and get a menu.
> 
> 2) Eliminate the separator bar in this menu.
> 
> 3) Have a hint appear for the Speak button (see image in jira) the first time you use the viewer, have voice on (the default), and successfully connect to a voice server.
> 
> 
> This addresses bug STORM-1077.
>     http://jira.secondlife.com/browse/STORM-1077
> 
> 
> Diffs
> -----
> 
>   indra/newview/llcallfloater.cpp b761ed94eb26 
>   indra/newview/llspeakbutton.cpp b761ed94eb26 
>   indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/229/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110324/07a98638/attachment.htm 


More information about the opensource-dev mailing list