[opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

Seth ProductEngine slitovchuk at productengine.com
Mon Mar 28 12:15:19 PDT 2011



> On March 28, 2011, 4:06 a.m., Oz Linden wrote:
> > indra/newview/llgesturemgr.cpp, lines 572-578
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line572>
> >
> >     Same possible race as above

Moved inserting the id into the mLoadingAssets prior to requesting asset data.

The getAssetData() request could potentially lead to memory leaks in some cases. Should this be a separate jira?


- Seth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/#review508
-----------------------------------------------------------


On March 25, 2011, 5:33 p.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/231/
> -----------------------------------------------------------
> 
> (Updated March 25, 2011, 5:33 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> First pass implementation of syncing the animations and sounds before the gesture starts playing.
> The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing.
> 
> 
> This addresses bug STORM-380.
>     http://jira.secondlife.com/browse/STORM-380
> 
> 
> Diffs
> -----
> 
>   indra/newview/llgesturemgr.h 6c15f820c3b9 
>   indra/newview/llgesturemgr.cpp 6c15f820c3b9 
> 
> Diff: http://codereview.secondlife.com/r/231/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110328/d6dc99a4/attachment.htm 


More information about the opensource-dev mailing list