[opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/232/#review519
-----------------------------------------------------------


Excellent! Except for a handful of minor typos, I've no problem with that code. One thing important though before we merge is to use the correct lgpl header for the new files.

I hope others will also review and try it out before we merge as it's a fair amount of code.


indra/llmessage/llpacketring.cpp
<http://codereview.secondlife.com/r/232/#comment398>

    Could write that in 1 line to make it easier to read.



indra/llmessage/llsocks5.h
<http://codereview.secondlife.com/r/232/#comment396>

    Incorrect license and header. Please use the same as for the rest of the code.



indra/llmessage/llsocks5.h
<http://codereview.secondlife.com/r/232/#comment399>

    Typo: available



indra/llmessage/llsocks5.h
<http://codereview.secondlife.com/r/232/#comment400>

    Typo: suppress final ";"



indra/llmessage/llsocks5.h
<http://codereview.secondlife.com/r/232/#comment401>

    naming convention: we prefix private member names with "m", not "h"



indra/llmessage/llsocks5.cpp
<http://codereview.secondlife.com/r/232/#comment397>

    Wrong license again



indra/llmessage/llsocks5.cpp
<http://codereview.secondlife.com/r/232/#comment402>

    Typos: association, associate



indra/llmessage/llsocks5.cpp
<http://codereview.secondlife.com/r/232/#comment403>

    Type: method



indra/llmessage/llsocks5.cpp
<http://codereview.secondlife.com/r/232/#comment404>

    Typo: indentation incorrect



indra/llmessage/net.cpp
<http://codereview.secondlife.com/r/232/#comment405>

    Typo: for



indra/llmessage/net.cpp
<http://codereview.secondlife.com/r/232/#comment406>

    Could you rephrase that warning? I can't really understand what it means. 



indra/llmessage/net.cpp
<http://codereview.secondlife.com/r/232/#comment407>

    Typo: connected



indra/newview/llfloaterpreference.cpp
<http://codereview.secondlife.com/r/232/#comment408>

    Typos: it's (verb), until



indra/newview/llstartup.cpp
<http://codereview.secondlife.com/r/232/#comment409>

    Typos: it's (verb)



indra/newview/llxmlrpctransaction.cpp
<http://codereview.secondlife.com/r/232/#comment410>

    Typos: incorrect indentation



indra/newview/skins/default/xui/en/floater_preferences_proxy.xml
<http://codereview.secondlife.com/r/232/#comment411>

    Typo: traffic


- Merov


On March 28, 2011, 4:46 a.m., Robin Cornelius wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/232/
> -----------------------------------------------------------
> 
> (Updated March 28, 2011, 4:46 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> VWR-20801 - Add ability to use SOCKS 5 proxy to the viewer. This allows the UDP and/or the http requests to be sent via a SOCKS 5 proxy. This also allows http proxies to be used for other http operations such as caps etc as required. All the proxy settings have been unified on a single proxy floater accessable from preferences. 
> 
> 
> This addresses bug VWR-20801.
>     http://jira.secondlife.com/browse/VWR-20801
> 
> 
> Diffs
> -----
> 
>   indra/llmessage/CMakeLists.txt 65ff7415f171 
>   indra/llmessage/llcurl.cpp 65ff7415f171 
>   indra/llmessage/llpacketring.h 65ff7415f171 
>   indra/llmessage/llpacketring.cpp 65ff7415f171 
>   indra/llmessage/llsocks5.h PRE-CREATION 
>   indra/llmessage/llsocks5.cpp PRE-CREATION 
>   indra/llmessage/net.h 65ff7415f171 
>   indra/llmessage/net.cpp 65ff7415f171 
>   indra/newview/app_settings/settings.xml 65ff7415f171 
>   indra/newview/llfloaterpreference.h 65ff7415f171 
>   indra/newview/llfloaterpreference.cpp 65ff7415f171 
>   indra/newview/llstartup.h 65ff7415f171 
>   indra/newview/llstartup.cpp 65ff7415f171 
>   indra/newview/llviewerfloaterreg.cpp 65ff7415f171 
>   indra/newview/llxmlrpctransaction.cpp 65ff7415f171 
>   indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/notifications.xml 65ff7415f171 
>   indra/newview/skins/default/xui/en/panel_preferences_setup.xml 65ff7415f171 
> 
> Diff: http://codereview.secondlife.com/r/232/diff
> 
> 
> Testing
> -------
> 
> Verified login and in world interaction with proxy disabled, verified login and in world interactionvia socks 5 proxy. Code has been tested on Windows very recently and has also worked fine on linux, but i'm not currently in a position to retest that or Mac at all. Much more testing is needed to verify this does not break anything unexpectedly and also works as expected when enabled. To test requires a working socks 5 proxy.
> 
> 
> Thanks,
> 
> Robin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110329/6e2a647c/attachment-0001.htm