[opensource-dev] Review Request: CHOP-624 header dependency improvements for build time speedup

[Brad Kittenbrink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/289/
-----------------------------------------------------------

(Updated May 4, 2011, 2:57 p.m.)


Review request for Viewer.


Changes
-------

Oops, swiched the patches when uploading, updated this issue with the info from the patch that actually got posted.


Summary (updated)
-------

Sorry for the big diff here, but reworking a LOT of header dependencies to reduce complexity and help build time.  Started moving stuff out of public interfaces of classes to improve insulation (for example in llviewerregion.h and llagent.h for the biggest examples).


This addresses bug CHOP-624.
    http://jira.secondlife.com/browse/CHOP-624


Diffs
-----

  indra/llcommon/llapp.cpp UNKNOWN 
  indra/llui/llbutton.h UNKNOWN 
  indra/llui/llfloaterreg.h UNKNOWN 
  indra/llui/llfocusmgr.h UNKNOWN 
  indra/llui/llfocusmgr.cpp UNKNOWN 
  indra/llui/lliconctrl.h UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/llloadingindicator.h UNKNOWN 
  indra/llui/llmultislider.cpp UNKNOWN 
  indra/llui/llpanel.h UNKNOWN 
  indra/llui/llprogressbar.h UNKNOWN 
  indra/llui/llprogressbar.cpp UNKNOWN 
  indra/llui/llslider.h UNKNOWN 
  indra/llui/llstyle.h UNKNOWN 
  indra/llui/llstyle.cpp UNKNOWN 
  indra/llui/lltransutil.cpp UNKNOWN 
  indra/llui/llui.h UNKNOWN 
  indra/llui/llview.h UNKNOWN 
  indra/llui/llviewborder.cpp UNKNOWN 
  indra/llui/llwindowshade.h UNKNOWN 
  indra/llxuixml/lltrans.h UNKNOWN 
  indra/llxuixml/lltrans.cpp UNKNOWN 
  indra/llxuixml/llxuiparser.h UNKNOWN 
  indra/newview/llagent.h UNKNOWN 
  indra/newview/llagent.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/lleventnotifier.h UNKNOWN 
  indra/newview/llfloaterland.h UNKNOWN 
  indra/newview/llfloaterland.cpp UNKNOWN 
  indra/newview/llfloatersnapshot.cpp UNKNOWN 
  indra/newview/llfolderviewitem.h UNKNOWN 
  indra/newview/lllocationhistory.h UNKNOWN 
  indra/newview/lloutputmonitorctrl.h UNKNOWN 
  indra/newview/llpanelavatar.cpp UNKNOWN 
  indra/newview/llpanelgroupgeneral.cpp UNKNOWN 
  indra/newview/llpanelgrouproles.cpp UNKNOWN 
  indra/newview/llpreviewgesture.cpp UNKNOWN 
  indra/newview/llsidepaneliteminfo.cpp UNKNOWN 
  indra/newview/lltooldraganddrop.cpp UNKNOWN 
  indra/newview/llviewerchat.cpp UNKNOWN 
  indra/newview/llviewerkeyboard.h UNKNOWN 
  indra/newview/llviewermenu.cpp UNKNOWN 
  indra/newview/llviewerparcelmgr.cpp UNKNOWN 
  indra/newview/llviewerprecompiledheaders.h UNKNOWN 
  indra/newview/llviewerregion.h UNKNOWN 
  indra/newview/llviewerregion.cpp UNKNOWN 
  indra/newview/llviewertexturelist.h UNKNOWN 
  indra/newview/llviewerwindow.h UNKNOWN 
  indra/newview/llviewerwindow.cpp UNKNOWN 
  indra/newview/llvoavatar.cpp UNKNOWN 
  indra/newview/llvotree.cpp UNKNOWN 
  indra/newview/llvovolume.cpp UNKNOWN 
  indra/newview/llworld.cpp UNKNOWN 
  indra/newview/tests/llremoteparcelrequest_test.cpp UNKNOWN 
  indra/newview/tests/llviewerhelputil_test.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/289/diff


Testing (updated)
-------


Thanks,

Brad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110504/690d1439/attachment-0001.htm