[opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

Boroondas Gupte sllists at boroon.dasgupta.ch
Tue May 10 04:38:57 PDT 2011
Previous message: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui
Next message: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/#review689
-----------------------------------------------------------


Review Board can only partially apply your patch. Please upload a diff file that works.

Some tips:

* Generate the diff file from hg rather than git, so that it contains revision IDs that RB knows about.

* If the change you want to review isn't based on a revision already in the repository you selected for this RB review request (lindenlab/viewer-development in this case), you must provide the diff between a known revision (i.e. one in lindenlab/viewer-development) and the base revision of your changeset as "Parent Diff".

* When creating a new review request or uploading a new diff file to an existing one, you can preview the diff (and see whether RB can apply it) before submitting the request/diff update by clicking the "View Diff" button.

** WARNING: Any changes to description, summary, tests done etc. that are being edited (i.e. have an "OK" and "Cancel" button visible) will be lost when you click "View Diff". To 'save' them (without submitting the request, yet), use the "OK" buttons associated with the respective input fields, and they will be kept while (p)reviewing your Diff.

- Boroondas


On May 9, 2011, 6:34 p.m., Brad Kittenbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/302/
> -----------------------------------------------------------
> 
> (Updated May 9, 2011, 6:34 p.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> -------
> 
> Started moving panel and floater classes into a new static library project in an effort to start promoting better insulation between model and view sections of the viewer codebase.  This is in preparation for further work breaking header dependencies along the lines of CHOP-624
> 
> 
> This addresses bug CHOP-658.
>     http://jira.secondlife.com/browse/CHOP-658
> 
> 
> Diffs
> -----
> 
>   indra/cmake/LLViewerUI.cmake PRE-CREATION 
>   indra/newview/CMakeLists.txt UNKNOWN 
>   indra/newview/llfloaterabout.h UNKNOWN 
>   indra/newview/llfloaterabout.cpp UNKNOWN 
>   indra/newview/llfloateranimpreview.h UNKNOWN 
>   indra/newview/llfloateranimpreview.cpp UNKNOWN 
>   indra/newview/llfloaterauction.h UNKNOWN 
>   indra/newview/llfloaterauction.cpp UNKNOWN 
>   indra/newview/llfloateravatarpicker.h UNKNOWN 
>   indra/newview/llfloateravatarpicker.cpp UNKNOWN 
>   indra/newview/llfloateravatartextures.h UNKNOWN 
>   indra/newview/llfloateravatartextures.cpp UNKNOWN 
>   indra/newview/llfloaterbeacons.h UNKNOWN 
>   indra/newview/llfloaterbeacons.cpp UNKNOWN 
>   indra/newview/llfloaterbuildoptions.h UNKNOWN 
>   indra/newview/llfloaterbuildoptions.cpp UNKNOWN 
>   indra/newview/llfloaterbulkpermission.h UNKNOWN 
>   indra/newview/llfloaterbulkpermission.cpp UNKNOWN 
>   indra/newview/llfloaterbump.h UNKNOWN 
>   indra/newview/llfloaterbump.cpp UNKNOWN 
>   indra/newview/llfloaterbuy.h UNKNOWN 
>   indra/newview/llfloaterbuy.cpp UNKNOWN 
>   indra/newview/llfloaterbuycontents.h UNKNOWN 
>   indra/newview/llfloaterbuycontents.cpp UNKNOWN 
>   indra/newview/llfloaterbuycurrency.h UNKNOWN 
>   indra/newview/llfloaterbuycurrency.cpp UNKNOWN 
>   indra/newview/llfloaterbuycurrencyhtml.h UNKNOWN 
>   indra/newview/llfloaterbuycurrencyhtml.cpp UNKNOWN 
>   indra/newview/llfloaterbuyland.h UNKNOWN 
>   indra/newview/llfloaterbuyland.cpp UNKNOWN 
>   indra/newview/llfloatercamera.h UNKNOWN 
>   indra/newview/llfloatercamera.cpp UNKNOWN 
>   indra/newview/llfloaterchat.h UNKNOWN 
>   indra/newview/llfloaterchat.cpp UNKNOWN 
>   indra/newview/llfloaterchatterbox.h UNKNOWN 
>   indra/newview/llfloaterchatterbox.cpp UNKNOWN 
>   indra/newview/llfloatercolorpicker.h UNKNOWN 
>   indra/newview/llfloatercolorpicker.cpp UNKNOWN 
>   indra/newview/llfloaterdaycycle.h UNKNOWN 
>   indra/newview/llfloaterdaycycle.cpp UNKNOWN 
>   indra/newview/llfloaterdisplayname.h UNKNOWN 
>   indra/newview/llfloaterdisplayname.cpp UNKNOWN 
>   indra/newview/llfloaterenvsettings.h UNKNOWN 
>   indra/newview/llfloaterenvsettings.cpp UNKNOWN 
>   indra/newview/llfloaterevent.h UNKNOWN 
>   indra/newview/llfloaterevent.cpp UNKNOWN 
>   indra/newview/llfloaterfonttest.h UNKNOWN 
>   indra/newview/llfloaterfonttest.cpp UNKNOWN 
>   indra/newview/llfloaterfriends.h UNKNOWN 
>   indra/newview/llfloaterfriends.cpp UNKNOWN 
>   indra/newview/llfloatergesture.h UNKNOWN 
>   indra/newview/llfloatergesture.cpp UNKNOWN 
>   indra/newview/llfloatergodtools.h UNKNOWN 
>   indra/newview/llfloatergodtools.cpp UNKNOWN 
>   indra/newview/llfloatergroupinvite.h UNKNOWN 
>   indra/newview/llfloatergroupinvite.cpp UNKNOWN 
>   indra/newview/llfloatergroups.h UNKNOWN 
>   indra/newview/llfloatergroups.cpp UNKNOWN 
>   indra/newview/llfloaterhandler.h UNKNOWN 
>   indra/newview/llfloaterhandler.cpp UNKNOWN 
>   indra/newview/llfloaterhardwaresettings.h UNKNOWN 
>   indra/newview/llfloaterhardwaresettings.cpp UNKNOWN 
>   indra/newview/llfloaterhelpbrowser.h UNKNOWN 
>   indra/newview/llfloaterhelpbrowser.cpp UNKNOWN 
>   indra/newview/llfloaterhud.h UNKNOWN 
>   indra/newview/llfloaterhud.cpp UNKNOWN 
>   indra/newview/llfloaterimagepreview.h UNKNOWN 
>   indra/newview/llfloaterimagepreview.cpp UNKNOWN 
>   indra/newview/llfloaterinspect.h UNKNOWN 
>   indra/newview/llfloaterinspect.cpp UNKNOWN 
>   indra/newview/llfloaterinventory.h UNKNOWN 
>   indra/newview/llfloaterinventory.cpp UNKNOWN 
>   indra/newview/llfloaterjoystick.h UNKNOWN 
>   indra/newview/llfloaterjoystick.cpp UNKNOWN 
>   indra/newview/llfloaterlagmeter.h UNKNOWN 
>   indra/newview/llfloaterlagmeter.cpp UNKNOWN 
>   indra/newview/llfloaterland.h UNKNOWN 
>   indra/newview/llfloaterland.cpp UNKNOWN 
>   indra/newview/llfloaterlandholdings.h UNKNOWN 
>   indra/newview/llfloaterlandholdings.cpp UNKNOWN 
>   indra/newview/llfloatermap.h UNKNOWN 
>   indra/newview/llfloatermap.cpp UNKNOWN 
>   indra/newview/llfloatermediabrowser.h UNKNOWN 
>   indra/newview/llfloatermediabrowser.cpp UNKNOWN 
>   indra/newview/llfloatermediasettings.h UNKNOWN 
>   indra/newview/llfloatermediasettings.cpp UNKNOWN 
>   indra/newview/llfloatermemleak.h UNKNOWN 
>   indra/newview/llfloatermemleak.cpp UNKNOWN 
>   indra/newview/llfloaternamedesc.h UNKNOWN 
>   indra/newview/llfloaternamedesc.cpp UNKNOWN 
>   indra/newview/llfloaternotificationsconsole.h UNKNOWN 
>   indra/newview/llfloaternotificationsconsole.cpp UNKNOWN 
>   indra/newview/llfloateropenobject.h UNKNOWN 
>   indra/newview/llfloateropenobject.cpp UNKNOWN 
>   indra/newview/llfloaterpay.h UNKNOWN 
>   indra/newview/llfloaterpay.cpp UNKNOWN 
>   indra/newview/llfloaterperms.h UNKNOWN 
>   indra/newview/llfloaterperms.cpp UNKNOWN 
>   indra/newview/llfloaterpostcard.h UNKNOWN 
>   indra/newview/llfloaterpostcard.cpp UNKNOWN 
>   indra/newview/llfloaterpostprocess.h UNKNOWN 
>   indra/newview/llfloaterpostprocess.cpp UNKNOWN 
>   indra/newview/llfloaterpreference.h UNKNOWN 
>   indra/newview/llfloaterpreference.cpp UNKNOWN 
>   indra/newview/llfloaterproperties.h UNKNOWN 
>   indra/newview/llfloaterproperties.cpp UNKNOWN 
>   indra/newview/llfloaterregiondebugconsole.h UNKNOWN 
>   indra/newview/llfloaterregiondebugconsole.cpp UNKNOWN 
>   indra/newview/llfloaterregioninfo.h UNKNOWN 
>   indra/newview/llfloaterregioninfo.cpp UNKNOWN 
>   indra/newview/llfloaterreporter.h UNKNOWN 
>   indra/newview/llfloaterreporter.cpp UNKNOWN 
>   indra/newview/llfloaterscriptdebug.h UNKNOWN 
>   indra/newview/llfloaterscriptdebug.cpp UNKNOWN 
>   indra/newview/llfloaterscriptlimits.h UNKNOWN 
>   indra/newview/llfloaterscriptlimits.cpp UNKNOWN 
>   indra/newview/llfloatersearch.h UNKNOWN 
>   indra/newview/llfloatersearch.cpp UNKNOWN 
>   indra/newview/llfloatersellland.h UNKNOWN 
>   indra/newview/llfloatersellland.cpp UNKNOWN 
>   indra/newview/llfloatersettingsdebug.h UNKNOWN 
>   indra/newview/llfloatersettingsdebug.cpp UNKNOWN 
>   indra/newview/llfloatersidetraytab.h UNKNOWN 
>   indra/newview/llfloatersidetraytab.cpp UNKNOWN 
>   indra/newview/llfloatersnapshot.h UNKNOWN 
>   indra/newview/llfloatersnapshot.cpp UNKNOWN 
>   indra/newview/llfloatertelehub.h UNKNOWN 
>   indra/newview/llfloatertelehub.cpp UNKNOWN 
>   indra/newview/llfloatertestinspectors.h UNKNOWN 
>   indra/newview/llfloatertestinspectors.cpp UNKNOWN 
>   indra/newview/llfloatertestlistview.h UNKNOWN 
>   indra/newview/llfloatertestlistview.cpp UNKNOWN 
>   indra/newview/llfloatertools.h UNKNOWN 
>   indra/newview/llfloatertools.cpp UNKNOWN 
>   indra/newview/llfloatertopobjects.h UNKNOWN 
>   indra/newview/llfloatertopobjects.cpp UNKNOWN 
>   indra/newview/llfloatertos.h UNKNOWN 
>   indra/newview/llfloatertos.cpp UNKNOWN 
>   indra/newview/llfloateruipreview.h UNKNOWN 
>   indra/newview/llfloateruipreview.cpp UNKNOWN 
>   indra/newview/llfloaterurlentry.h UNKNOWN 
>   indra/newview/llfloaterurlentry.cpp UNKNOWN 
>   indra/newview/llfloatervoiceeffect.h UNKNOWN 
>   indra/newview/llfloatervoiceeffect.cpp UNKNOWN 
>   indra/newview/llfloaterwater.h UNKNOWN 
>   indra/newview/llfloaterwater.cpp UNKNOWN 
>   indra/newview/llfloaterwebcontent.h UNKNOWN 
>   indra/newview/llfloaterwebcontent.cpp UNKNOWN 
>   indra/newview/llfloaterwhitelistentry.h UNKNOWN 
>   indra/newview/llfloaterwhitelistentry.cpp UNKNOWN 
>   indra/newview/llfloaterwindlight.h UNKNOWN 
>   indra/newview/llfloaterwindlight.cpp UNKNOWN 
>   indra/newview/llfloaterwindowsize.h UNKNOWN 
>   indra/newview/llfloaterwindowsize.cpp UNKNOWN 
>   indra/newview/llfloaterworldmap.h UNKNOWN 
>   indra/newview/llfloaterworldmap.cpp UNKNOWN 
>   indra/newview/llpanelappearancetab.h UNKNOWN 
>   indra/newview/llpanelappearancetab.cpp UNKNOWN 
>   indra/newview/llpanelavatar.h UNKNOWN 
>   indra/newview/llpanelavatar.cpp UNKNOWN 
>   indra/newview/llpanelavatartag.h UNKNOWN 
>   indra/newview/llpanelavatartag.cpp UNKNOWN 
>   indra/newview/llpanelblockedlist.h UNKNOWN 
>   indra/newview/llpanelblockedlist.cpp UNKNOWN 
>   indra/newview/llpanelclassified.h UNKNOWN 
>   indra/newview/llpanelclassified.cpp UNKNOWN 
>   indra/newview/llpanelcontents.h UNKNOWN 
>   indra/newview/llpanelcontents.cpp UNKNOWN 
>   indra/newview/llpaneleditwearable.h UNKNOWN 
>   indra/newview/llpaneleditwearable.cpp UNKNOWN 
>   indra/newview/llpanelface.h UNKNOWN 
>   indra/newview/llpanelface.cpp UNKNOWN 
>   indra/newview/llpanelgenerictip.h UNKNOWN 
>   indra/newview/llpanelgenerictip.cpp UNKNOWN 
>   indra/newview/llpanelgroup.h UNKNOWN 
>   indra/newview/llpanelgroup.cpp UNKNOWN 
>   indra/newview/llpanelgroupgeneral.h UNKNOWN 
>   indra/newview/llpanelgroupgeneral.cpp UNKNOWN 
>   indra/newview/llpanelgroupinvite.h UNKNOWN 
>   indra/newview/llpanelgroupinvite.cpp UNKNOWN 
>   indra/newview/llpanelgrouplandmoney.h UNKNOWN 
>   indra/newview/llpanelgrouplandmoney.cpp UNKNOWN 
>   indra/newview/llpanelgroupnotices.h UNKNOWN 
>   indra/newview/llpanelgroupnotices.cpp UNKNOWN 
>   indra/newview/llpanelgrouproles.h UNKNOWN 
>   indra/newview/llpanelgrouproles.cpp UNKNOWN 
>   indra/newview/llpanelhome.h UNKNOWN 
>   indra/newview/llpanelhome.cpp UNKNOWN 
>   indra/newview/llpanelimcontrolpanel.h UNKNOWN 
>   indra/newview/llpanelimcontrolpanel.cpp UNKNOWN 
>   indra/newview/llpanelland.h UNKNOWN 
>   indra/newview/llpanelland.cpp UNKNOWN 
>   indra/newview/llpanellandaudio.h UNKNOWN 
>   indra/newview/llpanellandaudio.cpp UNKNOWN 
>   indra/newview/llpanellandmarkinfo.h UNKNOWN 
>   indra/newview/llpanellandmarkinfo.cpp UNKNOWN 
>   indra/newview/llpanellandmarks.h UNKNOWN 
>   indra/newview/llpanellandmarks.cpp UNKNOWN 
>   indra/newview/llpanellandmedia.h UNKNOWN 
>   indra/newview/llpanellandmedia.cpp UNKNOWN 
>   indra/newview/llpanellogin.h UNKNOWN 
>   indra/newview/llpanellogin.cpp UNKNOWN 
>   indra/newview/llpanelloginlistener.h UNKNOWN 
>   indra/newview/llpanelloginlistener.cpp UNKNOWN 
>   indra/newview/llpanelmaininventory.h UNKNOWN 
>   indra/newview/llpanelmaininventory.cpp UNKNOWN 
>   indra/newview/llpanelme.h UNKNOWN 
>   indra/newview/llpanelme.cpp UNKNOWN 
>   indra/newview/llpanelmediasettingsgeneral.h UNKNOWN 
>   indra/newview/llpanelmediasettingsgeneral.cpp UNKNOWN 
>   indra/newview/llpanelmediasettingspermissions.h UNKNOWN 
>   indra/newview/llpanelmediasettingspermissions.cpp UNKNOWN 
>   indra/newview/llpanelmediasettingssecurity.h UNKNOWN 
>   indra/newview/llpanelmediasettingssecurity.cpp UNKNOWN 
>   indra/newview/llpanelnearbymedia.h UNKNOWN 
>   indra/newview/llpanelnearbymedia.cpp UNKNOWN 
>   indra/newview/llpanelobject.h UNKNOWN 
>   indra/newview/llpanelobject.cpp UNKNOWN 
>   indra/newview/llpanelobjectinventory.h UNKNOWN 
>   indra/newview/llpanelobjectinventory.cpp UNKNOWN 
>   indra/newview/llpanelonlinestatus.h UNKNOWN 
>   indra/newview/llpanelonlinestatus.cpp UNKNOWN 
>   indra/newview/llpaneloutfitedit.h UNKNOWN 
>   indra/newview/llpaneloutfitedit.cpp UNKNOWN 
>   indra/newview/llpaneloutfitsinventory.h UNKNOWN 
>   indra/newview/llpaneloutfitsinventory.cpp UNKNOWN 
>   indra/newview/llpanelpeople.h UNKNOWN 
>   indra/newview/llpanelpeople.cpp UNKNOWN 
>   indra/newview/llpanelpeoplemenus.h UNKNOWN 
>   indra/newview/llpanelpeoplemenus.cpp UNKNOWN 
>   indra/newview/llpanelpermissions.h UNKNOWN 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/llpanelpick.h UNKNOWN 
>   indra/newview/llpanelpick.cpp UNKNOWN 
>   indra/newview/llpanelpicks.h UNKNOWN 
>   indra/newview/llpanelpicks.cpp UNKNOWN 
>   indra/newview/llpanelplaceinfo.h UNKNOWN 
>   indra/newview/llpanelplaceinfo.cpp UNKNOWN 
>   indra/newview/llpanelplaceprofile.h UNKNOWN 
>   indra/newview/llpanelplaceprofile.cpp UNKNOWN 
>   indra/newview/llpanelplaces.h UNKNOWN 
>   indra/newview/llpanelplaces.cpp UNKNOWN 
>   indra/newview/llpanelplacestab.h UNKNOWN 
>   indra/newview/llpanelplacestab.cpp UNKNOWN 
>   indra/newview/llpanelprimmediacontrols.h UNKNOWN 
>   indra/newview/llpanelprimmediacontrols.cpp UNKNOWN 
>   indra/newview/llpanelprofile.h UNKNOWN 
>   indra/newview/llpanelprofile.cpp UNKNOWN 
>   indra/newview/llpanelprofileview.h UNKNOWN 
>   indra/newview/llpanelprofileview.cpp UNKNOWN 
>   indra/newview/llpanelteleporthistory.h UNKNOWN 
>   indra/newview/llpanelteleporthistory.cpp UNKNOWN 
>   indra/newview/llpaneltiptoast.h UNKNOWN 
>   indra/newview/llpaneltiptoast.cpp UNKNOWN 
>   indra/newview/llpaneltopinfobar.h UNKNOWN 
>   indra/newview/llpaneltopinfobar.cpp UNKNOWN 
>   indra/newview/llpanelvoicedevicesettings.h UNKNOWN 
>   indra/newview/llpanelvoicedevicesettings.cpp UNKNOWN 
>   indra/newview/llpanelvoiceeffect.h UNKNOWN 
>   indra/newview/llpanelvoiceeffect.cpp UNKNOWN 
>   indra/newview/llpanelvolume.h UNKNOWN 
>   indra/newview/llpanelvolume.cpp UNKNOWN 
>   indra/newview/llpanelvolumepulldown.h UNKNOWN 
>   indra/newview/llpanelvolumepulldown.cpp UNKNOWN 
>   indra/newview/llpanelwearing.h UNKNOWN 
>   indra/newview/llpanelwearing.cpp UNKNOWN 
>   indra/viewer_components/CMakeLists.txt UNKNOWN 
>   indra/viewer_components/viewerui/CMakeLists.txt PRE-CREATION 
>   indra/viewer_components/viewerui/llviewerui.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/302/diff
> 
> 
> Testing
> -------
> 
> No testing beyond checking that it builds so far.
> 
> 
> Thanks,
> 
> Brad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110510/a7a18730/attachment-0001.htm
Previous message: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui
Next message: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the opensource-dev mailing list