[opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review696
-----------------------------------------------------------

Ship it!



indra/llui/llnotifications.cpp
<http://codereview.secondlife.com/r/271/#comment668>

    Sorry, another change request ... Didn't see this at first:
    Please remove the trailing whitespace.


No other objections, so ship it!

(Not quite seeing through that forest of add methods and Param constructors, so I just have to trust Vadim picked the right function call here.)

- Boroondas


On May 12, 2011, 12:26 a.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> -----------------------------------------------------------
> 
> (Updated May 12, 2011, 12:26 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
>     http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 5e349dbe9cc8 
>   indra/llui/llnotifications.cpp 5e349dbe9cc8 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> -------
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110512/67b32c41/attachment.htm