[opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

[Wolfpup Lowenhar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/
-----------------------------------------------------------

(Updated May 16, 2011, 4:16 a.m.)


Review request for Viewer.


Changes
-------

sorry use wrong initial diff here is the correct diff


Summary
-------

This is for switching from using winres.h to windows.h so that the viewer can be build no matter whether your using and Express or Professional version of Visual Studio.


This addresses bug STORM-859.
    http://jira.secondlife.com/browse/STORM-859


Diffs (updated)
-----

  doc/contributions.txt e9d656e4620e 
  indra/newview/res/resource.h e9d656e4620e 
  indra/newview/res/viewerRes.rc e9d656e4620e 

Diff: http://codereview.secondlife.com/r/304/diff


Testing
-------

I have built viewer-development locally with this modification using Visual Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. It logs in to SL just fine.
I have done the following with the built viewer:
1. edited or created objects with no ill affects.
2. carried on conversations in Near By, Group and P2P with no ill affects.
3. Teleported to various sims and levels in those sims with no ill affect.
4. carried on Voice conversations with no ill affect.
5. moved things around in my inventory as well as rezed and taken objects from and to my inventory with no ill affects.


Thanks,

Wolfpup

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110516/6599b7fa/attachment.htm