[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/307/
-----------------------------------------------------------

(Updated May 18, 2011, 1:13 p.m.)


Review request for Viewer.


Changes
-------

* renamed the newly introduced method to convertFilenameToString
* moved implementations out of class body
* declared the (pre-existing) temporary string constant


Summary
-------

Some trickery needed to make this forward compatible to newer Boost versions while keeping compatibility to the currently used Boost version.


This addresses bug OPEN-67.
    http://jira.secondlife.com/browse/OPEN-67


Diffs (updated)
-----

  doc/contributions.txt 959f9340da92 
  indra/llvfs/lldiriterator.cpp 959f9340da92 

Diff: http://codereview.secondlife.com/r/307/diff


Testing
-------

* Compiled Viewer (standalone) with Boost 1.46
* Started Viewer
* Logged in

Not tested:
* non-standalone
* other boost versions (At least one version <= 1.43 should be tested! Preferably the one LL currently uses.)


Thanks,

Boroondas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110518/25e84f7c/attachment.htm