[opensource-dev] Review Request: Correctly identify Server 2008, Server 2008 R2, Server 2012, and Windows 8

[Brad Kittenbrink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/311/#review707
-----------------------------------------------------------

Ship it!


Looks good to me

- Brad


On May 17, 2011, 9:31 a.m., tankmaster.finesmith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/311/
> -----------------------------------------------------------
> 
> (Updated May 17, 2011, 9:31 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> The stated OS in help -> about for server 2008 and server 2008 R2 is inaccurate.  It shows up as "Microsoft Windows Vista Server" or "Microsoft Windows 7 Server" instead of "Microsoft Server 2008" or "Microsoft Server 2008 R2" respectively.  This patch corrects the text display error and also adds support for "Microsoft Server 2012" and "Microsoft Windows 8" which I have confirmed works on those OSs.  I came to this work by mimicking the code logic for how server 2003 was handled.
> 
> This patch does not correct the error of XP always showing up as running in compatibility mode.  This also doesn’t affect the redundant display of x64 for Server 2008 R2 and Server 2012, which are only available in 64bit versions.
> 
> I have applied my patch to my clone of viewer-dev at https://bitbucket.org/Tank_Master/storm-1258/changeset/f4b293bbdedf and my initial firestorm commit can be found at http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/6bf2de50ea83 
> 
> 
> This addresses bug STORM-1258.
>     http://jira.secondlife.com/browse/STORM-1258
> 
> 
> Diffs
> -----
> 
>   indra/llcommon/llsys.cpp ddfc2ed6aee1 
> 
> Diff: http://codereview.secondlife.com/r/311/diff
> 
> 
> Testing
> -------
> 
> I made this patch for Firestorm, where it was applied and tested initially and no errors have been found.
> 
> 
> Thanks,
> 
> tankmaster.finesmith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110519/33abf7ce/attachment.htm